Bug 216831

Summary: Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
Product: WebKit Reporter: Sam Weinig <sam>
Component: MediaAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, jer.noble, kangil.han, kondapallykalyan, philipj, rackler, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145411
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Sam Weinig 2020-09-22 09:35:25 PDT 
After talking with Eric Carlson, we think its time to remove all the code behind ENABLE(MEDIA_SESSION), no ports enable it and the spec has substantially changed since this was first implemented.
Comment 1 Sam Weinig 2020-09-22 18:29:49 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-22 19:28:10 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-23 04:37:20 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-23 04:56:24 PDT Comment hidden (obsolete)
Comment 5 EWS 2020-09-23 10:46:46 PDT Comment hidden (obsolete)
Comment 6 Radar WebKit Bug Importer 2020-09-29 09:36:13 PDT 
<rdar://problem/69750841>
Comment 7 Sam Weinig 2020-09-30 08:33:44 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-09-30 09:03:39 PDT Comment hidden (obsolete)
Comment 9 Sam Weinig 2020-09-30 09:11:03 PDT 
Created attachment 410129 [details]
Patch
Comment 10 EWS 2020-09-30 10:11:01 PDT 
Committed r267796: <https://trac.webkit.org/changeset/267796>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410129 [details].
Comment 11 Karl Rackler 2020-10-02 09:00:26 PDT 
Reverted r267796 for reason:

This change is breaking the build on internal debug bots.

Committed r267883: <https://trac.webkit.org/changeset/267883>
Comment 12 Karl Rackler 2020-10-02 09:25:12 PDT 
After reviewing with Tim and Sam relanding patch.
Comment 13 EWS 2020-10-02 09:39:51 PDT 
Committed r267885: <https://trac.webkit.org/changeset/267885>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410129 [details].