Bug 216830

Summary:

[GTK] REGRESSION(r267398): several hidpi tests are failing

Product:

WebKit

Reporter:

Diego Pino <dpino>

Component:

New Bugs

Assignee:

Lauro Moura <lmoura>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, lmoura, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Diego Pino 2020-09-22 09:24:16 PDT

The following tests are failing after r267398:

  fast/hidpi/clip-text-in-hidpi.html [ Failure ]
  fast/hidpi/image-srcset-change-dynamically-from-js-2x.html [ Failure ]
  fast/hidpi/image-srcset-fraction-1.5x.html [ Failure ]
  fast/hidpi/image-srcset-fraction.html [ Failure ]
  fast/hidpi/image-srcset-invalid-inputs-except-one.html [ Failure ]
  fast/hidpi/image-srcset-simple-2x.html [ Failure ]
  fast/hidpi/image-srcset-simple-in-variable-2x.html [ Failure ]
  fast/hidpi/image-srcset-src-selection-2x.html [ Failure ]

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r267406%20(15968)/results.html

Comment 1 Diego Pino 2020-09-22 09:29:39 PDT

Also: 

  fast/hidpi/image-set-gradient-multi.html [ ImageOnlyFailure ]
  fast/hidpi/image-set-gradient.html [ ImageOnlyFailure ]

Comment 2 Diego Pino 2020-09-22 10:23:35 PDT

These other tests also started failing in r267398:

  fast/dom/HTMLImageElement/sizes/image-sizes-2x.html [ Failure ]
  fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html [ Failure ]
  fast/events/mouse-cursor-image-set.html [ Failure 
  http/tests/loading/sizes/preload-image-sizes-2x.html [ Failure ]

Comment 3 Lauro Moura 2020-09-22 11:54:38 PDT

Created attachment 409386 [details]
Patch

Comment 4 Adrian Perez 2020-09-22 11:57:25 PDT

Comment on attachment 409386 [details]
Patch

Thanks for submitting this…

View in context: https://bugs.webkit.org/attachment.cgi?id=409386&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-3758
> -#if USE(CAIRO) && !HAVE(CAIRO_SURFACE_SET_DEVICE_SCALE)

Ouch, I feel silly for missing this in r267398 — I checked my shell history
and it turns out that I grepped around for HAVE_CAIRO_SURFACE_SET_DEVICE_SCALE
instead of just CAIRO_SURFACE_SET_DEVICE_SCALE 🤦️

Comment 5 EWS 2020-09-22 12:18:22 PDT

Committed r267431: <https://trac.webkit.org/changeset/267431>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409386 [details].

Comment 6 Radar WebKit Bug Importer 2020-09-22 12:19:17 PDT

<rdar://problem/69385138>