Bug 216826

Summary: [iOS] In case of live media capture, activate capture icon
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: NEW ---    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
Patch
none
Patch
none
Patch none

Description youenn fablet 2020-09-22 08:44:45 PDT 
[iOS] In case of live media capture, activate capture icon
Comment 1 youenn fablet 2020-09-28 09:27:28 PDT 
Created attachment 409890 [details]
WIP
Comment 2 Eric Carlson 2020-09-28 11:06:08 PDT 
Comment on attachment 409890 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=409890&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:41
> +ServiceWorkerDownloadTask::ServiceWorkerDownloadTask(WebSWServerConnection& connection, WebCore::FetchIdentifier fetchIdentifier, ServiceWorkerIdentifier serviceWorkerIdentifier, ServiceWorkerRegistrationIdentifier serviceWorkerRegistrationIdentifier, PendingDownload& download, DownloadID downloadID, const WebCore::ResourceRequest& request, const WebCore::ResourceResponse& response)

Did you mean to include this file?

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:47
> +class ServiceWorkerDownloadTask : public CanMakeWeakPtr<ServiceWorkerDownloadTask> {

Ditto.

> Source/WebKit/UIProcess/Cocoa/WKMediaCaptureStatusBarManager.mm:188
> +    RELEASE_LOG_ERROR(WebRTC, "WKMediaCaptureStatusBarManagerSource/WebCore/PAL/pal/cf/SpringBoardServicesSoftLink.h  did invalidate status bar");

I don't think you meant to include the path in the logging output.

> Source/WebKit/WebProcess/GPU/media/AudioOutputProvider.cpp:34
> +void AudioOutputProvider::defaultAudioOutputDeviceChanged(Page& page)

Oops, you probably didn't mean to include this.

> Source/WebKit/WebProcess/GPU/media/AudioOutputProvider.h:32
> +class AudioOutputProvider : public WebCore::AudioOutputProvider {

Ditto.
Comment 3 youenn fablet 2020-09-28 11:47:01 PDT 
Created attachment 409907 [details]
WIP
Comment 4 youenn fablet 2020-09-29 05:34:44 PDT 
Created attachment 409986 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2020-09-29 05:39:13 PDT 
<rdar://problem/69744048>
Comment 6 youenn fablet 2020-09-29 05:51:40 PDT 
Created attachment 409990 [details]
Patch
Comment 7 youenn fablet 2020-09-29 06:00:09 PDT 
Created attachment 409991 [details]
Patch