Bug 216823

Summary: REGRESSION(r267354): [Win] ImportError when starting wptserve
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Windows 10   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215829
Attachments:
Description Flags
Patch
none
Patch none

Sam Sneddon [:gsnedders]
Reported 2020-09-22 08:05:44 PDT
see e.g., https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Tests%29/builds/3494/steps/layout-test/logs/stdio; reported by Stephan Szabo on Slack, caused by the `import resource` which is a Unix-only module in the Python stdlib.
Attachments
Patch (1.80 KB, patch)
2020-09-22 08:34 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2020-09-22 09:08 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2020-09-22 08:34:46 PDT
Created attachment 409361 [details] Patch
EWS
Comment 2 2020-09-22 08:49:02 PDT
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Sam Sneddon [:gsnedders]
Comment 3 2020-09-22 09:08:01 PDT
Created attachment 409366 [details] Patch
EWS
Comment 4 2020-09-22 09:08:24 PDT
gsnedders@apple.com does not have committer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 409366 [details] from commit queue.
EWS
Comment 5 2020-09-22 09:53:36 PDT
Committed r267417: <https://trac.webkit.org/changeset/267417> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409366 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-22 09:54:20 PDT
<rdar://problem/69376367>
Note You need to log in before you can comment on or make changes to this bug.