| Summary: | Refactor build rules in Makefiles and Makefile.shared | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
| Component: | Tools / Tests | Assignee: | Keith Rollin <krollin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, ddkilzer, mark.lam, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Rollin
2020-09-21 15:40:00 PDT
Created attachment 409329 [details]
Patch
David, I really did a number on your set-sanitizer-configuration target. I think that what remains is equivalent to what you'd been doing, but I didn't understand all of what you'd implemented, so I'm not sure. Comment on attachment 409329 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409329&action=review r=me > Source/Makefile:22 > + @$(build_target_for_each_module) This doesn't need to be @$(call build_target_for_each_module) as done in Makefile.shared? Is that because we don't need to pass arguments? > Makefile.shared:101 > + [[ -t 1 ]] && COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; \ I'm sorry, what does `[[ -t 1 ]]` do?! > Makefile.shared:123 > + @$(call set_webkit_configuration,--debug --force-optimization-level=O3) This won't pass `--debug --force-optimization-level=O3` as a single string to the shell, will it? (In reply to David Kilzer (:ddkilzer) from comment #4) > Comment on attachment 409329 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409329&action=review > > r=me > > > Source/Makefile:22 > > + @$(build_target_for_each_module) > > This doesn't need to be @$(call build_target_for_each_module) as done in > Makefile.shared? Is that because we don't need to pass arguments? Correct. > > > Makefile.shared:101 > > + [[ -t 1 ]] && COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; \ > > I'm sorry, what does `[[ -t 1 ]]` do?! It checks to see if the specified file descriptor (in this case, stdout) is associated with a terminal. > > > Makefile.shared:123 > > + @$(call set_webkit_configuration,--debug --force-optimization-level=O3) > > This won't pass `--debug --force-optimization-level=O3` as a single string > to the shell, will it? No. I checked for that. `Make` performs a simply text replacement and then processes the resulting string. Committed r267424: <https://trac.webkit.org/changeset/267424> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409329 [details]. Committed r267441: <https://trac.webkit.org/changeset/267441> |