Bug 216797

Summary: [macOS] Start collecting telemetry from a set of XPC services
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216847
Bug Depends on: 216864    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2020-09-21 12:56:18 PDT
Start collecting telemetry for a set of XPC services in the WebContent process on macOS, in order to learn more about how they are used.
Comment 1 Per Arne Vollan 2020-09-21 13:09:32 PDT
Created attachment 409308 [details]
Patch
Comment 2 Brent Fulgham 2020-09-22 10:43:19 PDT
Comment on attachment 409308 [details]
Patch

r=me
Comment 3 Per Arne Vollan 2020-09-22 11:00:44 PDT
Comment on attachment 409308 [details]
Patch

Thanks for reviewing!
Comment 4 EWS 2020-09-22 11:03:20 PDT
Committed r267421: <https://trac.webkit.org/changeset/267421>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409308 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-22 11:43:49 PDT
<rdar://problem/69383147>
Comment 6 WebKit Commit Bot 2020-09-22 19:36:24 PDT
Re-opened since this is blocked by bug 216864
Comment 7 Ryan Haddad 2020-09-22 20:52:01 PDT
(In reply to WebKit Commit Bot from comment #6)
> Re-opened since this is blocked by bug 216864
This change was reverted because it broke TestWebKitAPI.WebKit.AccessibilityHasNoPreferencesServiceAccessWhenPostingNotification, as documented in https://bugs.webkit.org/show_bug.cgi?id=216847.
Comment 8 Per Arne Vollan 2020-09-23 07:50:19 PDT
Created attachment 409474 [details]
Patch
Comment 9 Brent Fulgham 2020-09-23 10:36:00 PDT
Comment on attachment 409474 [details]
Patch

r=me
Comment 10 Per Arne Vollan 2020-09-23 10:37:01 PDT
(In reply to Brent Fulgham from comment #9)
> Comment on attachment 409474 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 11 EWS 2020-09-23 10:55:39 PDT
Committed r267490: <https://trac.webkit.org/changeset/267490>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409474 [details].