| Summary: | Change render tree selection painting code to use non-canonicalized points | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | HTML Editing | Assignee: | Darin Adler <darin> | ||||
| Status: | ASSIGNED --- | ||||||
| Severity: | Normal | CC: | ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=216325 | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2020-09-19 18:38:34 PDT
Created attachment 409220 [details]
Patch
OK, turns out I misunderstood the code here. It’s calling a setSelection function on the render tree, which should not have any effect on the selection in the DOM. But somehow it did have an effect. Need to restore the old code and figure out what was happening. Not sure I need to do this any time soon. It’s nice to improve how we tie painting the selection to the DOM to not rely on so much editing strangeness. But not needed for the Selection API project. |