Bug 216718

Summary:

[macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting selected content as rich text data

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

katherine_cheney, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+
Patch for landing	none

Description Wenson Hsieh 2020-09-18 16:07:46 PDT

<rdar://problem/69150358>

Comment 1 Wenson Hsieh 2020-09-18 16:22:33 PDT

Created attachment 409177 [details]
Patch

Comment 2 Tim Horton 2020-09-18 17:16:51 PDT

Comment on attachment 409177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409177&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:43
> +#if PLATFORM(MAC)

An alternative (better???) way to write this would be to add conformance to NSServicesMenuRequestor on a category.

Comment 3 Wenson Hsieh 2020-09-18 17:17:56 PDT

Comment on attachment 409177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409177&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:43
>> +#if PLATFORM(MAC)
> 
> An alternative (better???) way to write this would be to add conformance to NSServicesMenuRequestor on a category.

Will do!

Comment 4 Wenson Hsieh 2020-09-18 17:21:49 PDT

Created attachment 409182 [details]
Patch for landing

Comment 5 EWS 2020-09-18 18:34:48 PDT

Committed r267305: <https://trac.webkit.org/changeset/267305>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409182 [details].