Bug 216694

Summary: [LFC][FFC] Add flex box/item to showLayoutTree
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2020-09-18 03:47:20 PDT 
ssia
Comment 1 zalan 2020-09-18 03:49:55 PDT 
Created attachment 409125 [details]
Patch
Comment 2 Sam Weinig 2020-09-18 10:32:23 PDT 
Comment on attachment 409125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409125&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:453
> +        stream << "Fkex box";

typo. Fkex -> Flex
Comment 3 zalan 2020-09-18 10:33:36 PDT 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 409125 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409125&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:453
> > +        stream << "Fkex box";
> 
> typo. Fkex -> Flex
never post patches at 4am.
Comment 4 zalan 2020-09-18 16:47:48 PDT 
Created attachment 409179 [details]
Patch
Comment 5 EWS 2020-09-18 17:40:44 PDT 
Committed r267303: <https://trac.webkit.org/changeset/267303>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409179 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-18 17:41:15 PDT 
<rdar://problem/69185543>
Comment 7 Simon Fraser (smfr) 2020-09-18 20:10:35 PDT 
Layout::Boxes need a virtual String debugDescription() const so they can print themselves.
Comment 8 zalan 2020-09-19 05:45:54 PDT 
(In reply to Simon Fraser (smfr) from comment #7)
> Layout::Boxes need a virtual String debugDescription() const so they can
> print themselves.
Since the LayoutBox has a rather flat class hierarchy (LFC tree is not typed as heavily as the render tree) we would probably end up with a big switch in Layout::Box. I'd rather keep it separate for now.