Bug 216690

Summary:

REGRESSION (r263179): CSS checkbox no longer visible in iOS 14

Product:

WebKit

Reporter:

Martin <martiminchev>

Component:

Layout and Rendering

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Major

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, graouts, kondapallykalyan, martiminchev, pdr, pxlcoder, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Other

Attachments:

Description	Flags
iOS 14 screen recording	none
Intended behaviour, as it is in iOS 13	none
Patch	simon.fraser: review+

Description Martin 2020-09-18 01:59:56 PDT

Created attachment 409116 [details]
iOS 14 screen recording

Since updating my iPad to iOS 14, the checkbox from this demo no longer works: https://codepen.io/abottega/pen/vNzQMo/?editors=1100
The check inside the box does not appear, though it does appear to toggle. So, it's probably only a visual bug. Unfortunately, users are unable to see if the checkbox is checked or not, making it a significant visual bug.

Comment 1 Martin 2020-09-18 02:02:12 PDT

Created attachment 409117 [details]
Intended behaviour, as it is in iOS 13

Comment 2 Radar WebKit Bug Importer 2020-09-18 09:40:52 PDT

<rdar://problem/69156576>

Comment 3 Alexey Proskuryakov 2020-09-19 11:28:00 PDT

This affects Safari 14 on macOS too.

Comment 4 Simon Fraser (smfr) 2020-09-22 15:51:16 PDT

Autosapde says r263179.

Comment 5 Antoine Quint 2020-10-21 08:06:34 PDT

I reduced it to this simple content:

<div style="box-shadow: 0 0 0 5px"></div>

Comment 6 Antoine Quint 2020-11-05 09:12:05 PST

Created attachment 413308 [details]
Patch

Comment 7 Simon Fraser (smfr) 2020-11-05 09:27:15 PST

Comment on attachment 413308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413308&action=review

> Source/WebCore/ChangeLog:14
> +        within en element's clipped bounds before considering its children. Whether the

an

> LayoutTests/fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container-2.html:55
> +result.textContent = `${pass ? "PASS" : "FAIL"}: target element class is "{hitTestElement.className}"`;

missing $

Comment 8 Antoine Quint 2020-11-05 10:36:22 PST

Committed r269450: <https://trac.webkit.org/changeset/269450>