| Summary: | [LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-09-17 18:40:40 PDT
Created attachment 409099 [details]
Patch
Comment on attachment 409099 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409099&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:52 > + const Box& root() const { return formattingContext().root(); } or rootBox()? > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:59 > +struct HangingContent { It's not clear to me what "hanging" is in this context. Created attachment 409123 [details]
Patch
Committed r267234: <https://trac.webkit.org/changeset/267234> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409123 [details]. |