Bug 216651

Summary: Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks to clarify what this enum value is for.
Product: WebKit Reporter: Hoa Dinh <dvh>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, cdumez, cgarcia, ews-watchlist, gustavo, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Hoa Dinh 2020-09-17 09:50:40 PDT 
During my investigation, it was hard to figure out what ShouldAllowExternalSchemes implied.
Renaming ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks should clarify what this enum value is for.
Comment 1 Hoa Dinh 2020-09-17 10:10:13 PDT 
Created attachment 409048 [details]
Patch
Comment 2 EWS Watchlist 2020-09-17 10:10:50 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS 2020-09-17 11:54:10 PDT 
Committed r267203: <https://trac.webkit.org/changeset/267203>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409048 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-17 11:55:22 PDT 
<rdar://problem/69085506>