Bug 216639

Summary: [CMake] Replace CMAKE_BINARY_DIR and CMAKE_SOURCE_DIR with PROJECT_BINARY_DIR and PROJECT_SOURCE_DIR
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CMakeAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED WONTFIX    
Severity: Normal CC: annulen, benjamin, berto, cdumez, cgarcia, cmarcelo, don.olmstead, ews-watchlist, gustavo, gyuyoung.kim, hi, jbedard, keith_miller, krollin, mark.lam, msaboff, rniwa, ross.kirsling, ryuan.choi, saam, sergio, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch don.olmstead: review-

Fujii Hironori
Reported 2020-09-17 00:13:21 PDT
[CMake] Replace CMAKE_BINARY_DIR and CMAKE_SOURCE_DIR with PROJECT_BINARY_DIR and PROJECT_SOURCE_DIR So that outside CMake projects can use WebKit as a submodule by add_subdirectory(WebKit).
Attachments
Patch (102.29 KB, patch)
2020-09-17 00:18 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (101.44 KB, patch)
2020-09-17 00:28 PDT, Fujii Hironori 		don.olmstead: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-09-17 00:18:29 PDT
Created attachment 408999 [details] Patch
Fujii Hironori
Comment 2 2020-09-17 00:28:08 PDT
Created attachment 409000 [details] Patch
Don Olmstead
Comment 3 2020-09-17 12:50:35 PDT
Comment on attachment 409000 [details] Patch I really think any project trying to use WebKit like this should be using https://cmake.org/cmake/help/latest/module/ExternalProject.html
Konstantin Tokarev
Comment 4 2020-09-17 13:00:05 PDT
I agree, add_subdirectory(WebKit) has big potential of changing global CMake state and we certainly don't want to debug such cases.
Note You need to log in before you can comment on or make changes to this bug.