Bug 216623

Summary:

AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

212611

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Chris Dumez 2020-09-16 15:37:21 PDT

AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0.

Comment 1 Chris Dumez 2020-09-16 15:42:41 PDT

Created attachment 408960 [details]
Patch

Comment 2 Eric Carlson 2020-09-16 16:23:39 PDT

Comment on attachment 408960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408960&action=review

> Source/WebCore/ChangeLog:10
> +        begining out the destination buffer, ignoring the computed writeIndex. As a result,

s/out/of/

Comment 3 Chris Dumez 2020-09-16 16:26:14 PDT

Committed r267170: <https://trac.webkit.org/changeset/267170>

Comment 4 Radar WebKit Bug Importer 2020-09-16 16:27:18 PDT

<rdar://problem/69023062>