| Summary: | Fixed some corner cases of scrolling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | cathiechen <cathiechen> | ||||
| Component: | Scrolling | Assignee: | cathiechen <cathiechen> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, cmarcelo, ews-watchlist, fred.wang, herr.ernst, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=216870 https://bugs.webkit.org/show_bug.cgi?id=216875 |
||||||
| Attachments: |
|
||||||
|
Description
cathiechen
2020-09-16 07:29:31 PDT
Created attachment 408922 [details]
Patch
Hi Simon and Fred, This patch fixes some corner case I met while implementing scrollend event. I think it'd good to have a separating bug to fix these for the scrollend patch is getting big now. Please take a look, thanks:) Comment on attachment 408922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408922&action=review > Source/WebCore/ChangeLog:3 > + Fixed some corner cases of scrolling This is a bit vague. Maybe it indicates that this patch should really be separated. Are any of these fixes testable? Comment on attachment 408922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408922&action=review Hi Simon, Thanks for the review:) >> Source/WebCore/ChangeLog:3 >> + Fixed some corner cases of scrolling > > This is a bit vague. Maybe it indicates that this patch should really be separated. > > Are any of these fixes testable? Yeah, I think it's a good idea to split them. These fixes are not very related. I couldn't find a good tile for them. Regarding the test, maybe we can create one for user scroll interrupt the programmatic scroll animation. Others seem not easy to test, for they only effect the internal state. It seems this r+ patch didn’t landed, do we need to fix these issues now? I think we do want these, but the patch needs splitting up, and some tests written. Ah, ok, let me take a look at it today:) |