| Summary: | [Flatpak SDK] bwrap: add pipewire socket as bind mount | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Víctor M. Jáquez L. <vjaquez> | ||||||
| Component: | Tools / Tests | Assignee: | Víctor M. Jáquez L. <vjaquez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, pnormand, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Víctor M. Jáquez L.
2020-09-16 03:32:56 PDT
Created attachment 408910 [details]
Patch
pipewire 0.3 is already merged in Debian testing Comment on attachment 408910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408910&action=review > Tools/ChangeLog:9 > + pipewire server version is bigger than 0.3 Why is it needed to check the version? (In reply to Philippe Normand from comment #3) > Comment on attachment 408910 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408910&action=review > > > Tools/ChangeLog:9 > > + pipewire server version is bigger than 0.3 > > Why is it needed to check the version? I thought it would be cumbersome to add a binding mountpoint to an useless socket (or does the client support back compatibility?). But still, the drawback of it, as far as I'm aware, is it should be upgraded when the pipewire protocol is upgraded. Comment on attachment 408910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408910&action=review >>> Tools/ChangeLog:9 >>> + pipewire server version is bigger than 0.3 >> >> Why is it needed to check the version? > > I thought it would be cumbersome to add a binding mountpoint to an useless socket (or does the client support back compatibility?). > > But still, the drawback of it, as far as I'm aware, is it should be upgraded when the pipewire protocol is upgraded. Another option could be to add it in `try_bind_mounts` and let bwrap itself check the existence of the socket. Created attachment 409047 [details]
Patch
Committed r267200: <https://trac.webkit.org/changeset/267200> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409047 [details]. |