| Summary: | [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, cdumez, esprehn+autocc, ews-watchlist, gyuyoung.kim, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2020-09-15 16:10:41 PDT
Created attachment 408878 [details]
Patch
Comment on attachment 408878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408878&action=review > Source/WebCore/page/Navigator.idl:28 > + // FIXME: Remove this. WebKit is the only engine that still has this. we could create a bugzilla for it. > Source/WebCore/page/Navigator.idl:36 > +Navigator includes NavigatorCookies; Should probably be the first includes to keep lexical order. (In reply to youenn fablet from comment #2) > Comment on attachment 408878 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408878&action=review > > > Source/WebCore/page/Navigator.idl:28 > > + // FIXME: Remove this. WebKit is the only engine that still has this. > > we could create a bugzilla for it. > > > Source/WebCore/page/Navigator.idl:36 > > +Navigator includes NavigatorCookies; > > Should probably be the first includes to keep lexical order. This was done to match the order in the spec. Committed r267146: <https://trac.webkit.org/changeset/267146> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408878 [details]. |