| Summary: | Move TLS certificate bypass SPI from WebProcessPool to WebsiteDataStore | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | berto, cgarcia, ews-watchlist, ggaren, gustavo, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Alex Christensen
2020-09-15 14:39:17 PDT
Created attachment 408865 [details]
Patch
Comment on attachment 408865 [details]
Patch
r=me
Created attachment 408866 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 408867 [details]
Patch
Comment on attachment 408867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408867&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:636 > +- (void)_allowTLSCertificate:(NSArray *)certificateChain forHost:(NSString *)host I'm going to call this _allowCertificateChain:forHost: because a certificate is one element of the array. Comment on attachment 408867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408867&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:636 >> +- (void)_allowTLSCertificate:(NSArray *)certificateChain forHost:(NSString *)host > > I'm going to call this _allowCertificateChain:forHost: because a certificate is one element of the array. _allowTLSCertificateChain Created attachment 408880 [details]
Patch
Comment on attachment 408880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408880&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1628 > - context->priv->processPool->allowSpecificHTTPSCertificateForHost(webCertificateInfo.ptr(), String::fromUTF8(host)); > + WebsiteDataStore::defaultDataStore()->allowSpecificHTTPSCertificateForHost(webCertificateInfo.ptr(), String::fromUTF8(host)); This should be: auto& websiteDataStore = webkitWebsiteDataManagerGetDataStore(context->priv->websiteDataManager.get()); websiteDataStore.allowSpecificHTTPSCertificateForHost(webCertificateInfo.ptr(), String::fromUTF8(host)); The GLib API doesn't use the default data store. Created attachment 408927 [details]
Patch
Committed r267155: <https://trac.webkit.org/changeset/267155> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408927 [details]. |