| Summary: | Import OscillatorNode layout tests from Blink | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=216625 | ||||||||||||
| Bug Depends on: | 216625 | ||||||||||||
| Bug Blocks: | 212611, 216576 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2020-09-15 10:16:44 PDT
Created attachment 408829 [details]
Patch
EWS seems angry. Created attachment 408841 [details]
Patch
Created attachment 408843 [details]
Patch
Created attachment 408848 [details]
Patch
Comment on attachment 408848 [details]
Patch
Ready for review.
Comment on attachment 408848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408848&action=review > LayoutTests/ChangeLog:8 > + Import OscillatorNode layout tests from Blink. Do you know why these are not WPT tests? Can we move them to LayoutTests/imported/w3c/web-platform-tests/webaudio and upstream them? They are already testharness based so should be fine. That will make sure these tests will be kept in sync with Blink. (In reply to youenn fablet from comment #7) > Comment on attachment 408848 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408848&action=review > > > LayoutTests/ChangeLog:8 > > + Import OscillatorNode layout tests from Blink. > > Do you know why these are not WPT tests? > Can we move them to LayoutTests/imported/w3c/web-platform-tests/webaudio and > upstream them? They are already testharness based so should be fine. > That will make sure these tests will be kept in sync with Blink. These are Blink tests. I do not know why they were not upstreamed. I don't think we should be the ones to upstream them. Until they are upstreamed, the best thing I can do to gain test coverage and make sure we match Chrome behavior is to import them. This is blocking my work. Tools/Scripts/svn-apply failed to apply attachment 408848 [details] to trunk.
Please resolve the conflicts and upload a new patch.
I filed https://github.com/web-platform-tests/wpt/issues/25571, hopefully Chromium can do the upstream and we could then remove our own copy. |