Bug 216566

Summary:

[ews] Improve failure summary string for AnalyzeCompileWebKitResults step

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=215174

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-09-15 09:51:19 PDT

Improve failure summary string for AnalyzeCompileWebKitResults step. In case of failure it currently says: "analyze-compile-webkit-results (failure)". Instead, it should be something like: "Patch 407575 does not build". e.g.: https://ews-build.webkit.org/#/builders/29/builds/18342

Note that this was working fine earlier, and probably broke with r265302.

Comment 1 Aakash Jain 2020-09-15 10:06:56 PDT

Created attachment 408826 [details]
Patch

Comment 2 Aakash Jain 2020-09-15 11:24:54 PDT

Tested in:
https://ews-build.webkit-uat.org/#/builders/35/builds/6169
https://ews-build.webkit-uat.org/#/builders/35/builds/6175

Comment 3 EWS 2020-09-16 14:52:56 PDT

Committed r267161: <https://trac.webkit.org/changeset/267161>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408826 [details].

Comment 4 Radar WebKit Bug Importer 2020-09-16 14:53:17 PDT

<rdar://problem/69016168>

Comment 5 Aakash Jain 2020-09-18 04:52:26 PDT

Restarted buildbot to pick up this change.

Comment 6 Aakash Jain 2020-09-21 10:26:52 PDT

Working fine, e.g.: https://ews-build.webkit.org/#/builders/29/builds/19951