| Summary: | Clean up lazy frame loading | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
| Component: | Frames | Assignee: | Rob Buis <rbuis> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Buis
2020-09-15 09:26:39 PDT
Created attachment 408825 [details]
Patch
Created attachment 408900 [details]
Patch
Comment on attachment 408900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408900&action=review > Source/WebKit/Shared/WebPreferences.yaml:2002 > + humanReadableName: "Lazy Iframe Loading" Should it be spelled IFrame? Ditto above for LazyIFrameLoadingEnabled. Created attachment 409013 [details]
Patch
Comment on attachment 408900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408900&action=review >> Source/WebKit/Shared/WebPreferences.yaml:2002 >> + humanReadableName: "Lazy Iframe Loading" > > Should it be spelled IFrame? > Ditto above for LazyIFrameLoadingEnabled. For the actual web preference I am copying ThirdPartyIframeRedirectBlockingEnabled. To avoid this naming problem I just lowercase to iframe now in the description, like ThirdPartyIframeRedirectBlockingEnabled does. Committed r267187: <https://trac.webkit.org/changeset/267187> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409013 [details]. |