| Summary: | [JSC] Intl.Collator should take collation option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 213425 | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-09-14 22:55:18 PDT
Created attachment 408797 [details]
Patch
Comment on attachment 408797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408797&action=review r=me > Source/JavaScriptCore/runtime/IntlCollator.cpp:185 > + throwRangeError(globalObject, scope, "collation must be unicode-locale-identifier's \"type\""_s); Hmm, we shouldn't require the user to know Unicode spec productions. 😅 To match what we've done in other Intl classes, I would suggest "collation is not a well-formed collation value". Comment on attachment 408797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408797&action=review Thanks! >> Source/JavaScriptCore/runtime/IntlCollator.cpp:185 >> + throwRangeError(globalObject, scope, "collation must be unicode-locale-identifier's \"type\""_s); > > Hmm, we shouldn't require the user to know Unicode spec productions. 😅 > To match what we've done in other Intl classes, I would suggest "collation is not a well-formed collation value". That's good! Changed. Committed r267102: <https://trac.webkit.org/changeset/267102> |