Bug 216473

Summary: Move Media in GPU Process flag from internal to experimental
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: REOPENED ---    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, peng.liu6, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description youenn fablet 2020-09-14 01:09:59 PDT 
Move Media in GPU Process flag from internal to experimental
Comment 1 youenn fablet 2020-09-14 01:10:55 PDT 
Created attachment 408687 [details]
Patch
Comment 2 youenn fablet 2020-09-14 02:57:58 PDT 
Created attachment 408697 [details]
Patch
Comment 3 youenn fablet 2020-09-16 08:43:57 PDT 
ping review
Comment 4 Jonathan Bedard 2020-09-16 08:58:49 PDT 
(In reply to youenn fablet from comment #3)
> ping review

I don't think I'm the right reviewer for this.
Comment 5 Peng Liu 2020-09-18 13:42:47 PDT 
Comment on attachment 408697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408697&action=review

> Tools/WebKitTestRunner/TestController.cpp:840
> +    // All experimental features except:

Do we need to move this code section down? After the loop?
Comment 6 youenn fablet 2020-09-19 00:26:30 PDT 
Comment on attachment 408697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408697&action=review

>> Tools/WebKitTestRunner/TestController.cpp:840
>> +    // All experimental features except:
> 
> Do we need to move this code section down? After the loop?

No, we want to have options set inside the tests to override the default values.
In the future, we could update the WebPrefereneces.yank script to add an option to opt out some of the experimental features.
Comment 7 Radar WebKit Bug Importer 2020-09-21 12:09:07 PDT 
<rdar://problem/69318786>
Comment 8 youenn fablet 2020-09-22 00:16:54 PDT 
Created attachment 409352 [details]
Patch for landing
Comment 9 youenn fablet 2020-09-22 00:36:07 PDT 
Created attachment 409354 [details]
Patch for landing
Comment 10 EWS 2020-09-22 05:11:02 PDT 
Committed r267403: <https://trac.webkit.org/changeset/267403>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409354 [details].
Comment 11 Truitt Savell 2020-09-23 09:04:05 PDT 
Reverted r267403 for reason:

Caused 50+ Crashes on iOS Debug

Committed r267479: <https://trac.webkit.org/changeset/267479>