Bug 216469

Summary: [TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Fujii Hironori 2020-09-13 19:50:46 PDT 
[TestRunnerShared] Make UIScriptController::windowIsKey and UIScriptController::setWindowIsKey virtual

I'd like to make TestRunnerShared as a standalone library which
doesn't depend on DRT and WTR (Bug 216465). Those methods were
added by r263979.
Comment 1 Fujii Hironori 2020-09-13 19:58:29 PDT 
Created attachment 408674 [details]
Patch
Comment 2 Fujii Hironori 2020-09-13 21:20:27 PDT 
Created attachment 408680 [details]
Patch
Comment 3 Fujii Hironori 2020-09-13 22:01:57 PDT 
Created attachment 408681 [details]
Patch
Comment 4 Fujii Hironori 2020-09-14 13:33:58 PDT 
Created attachment 408742 [details]
Patch
Comment 5 Darin Adler 2020-09-15 12:52:47 PDT 
Comment on attachment 408742 [details]
Patch

Seems OK. I have a huge patch with lots of simplifications to TestRunnerShared that I better land soon.
Comment 6 Fujii Hironori 2020-09-15 17:23:05 PDT 
Comment on attachment 408742 [details]
Patch

Clearing flags on attachment: 408742

Committed r267120: <https://trac.webkit.org/changeset/267120>
Comment 7 Fujii Hironori 2020-09-15 17:23:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-09-15 17:24:21 PDT 
<rdar://problem/68952059>