| Summary: | [LFC Display] First steps towards LFC painting in WebKit2 | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | annulen, bfulgham, darin, ews-watchlist, gyuyoung.kim, koivisto, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 216482 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Simon Fraser (smfr)
2020-09-13 16:10:29 PDT
Created attachment 408665 [details]
Patch
Created attachment 408666 [details]
Patch
Comment on attachment 408666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408666&action=review > Source/WebCore/layout/display/DisplayLayerController.cpp:83 > + if (!layoutState.hasDisplayBox(rootLayoutBox)) > + return; Shouldn't this be an ASSERT instead? We should never try to paint unless we have computed geometry (completed a layout). > Source/WebCore/layout/display/DisplayView.cpp:89 > + extra line > Source/WebCore/layout/display/DisplayView.h:65 > + // FIXME: Do we need to use LayoutTreeContent? I really hope not. I think we should figure out a way to have no dependency on LayoutState either. Display::Boxes are part of the state as they provide geometry information to subsequent layouts. However it seems a bit odd to see LayoutState in the context of painting and hittesting (this is not new to this patch) Created attachment 408678 [details]
Patch
Created attachment 408719 [details]
Patch
Created attachment 408721 [details]
Patch
Created attachment 408723 [details]
Patch
Committed r267024: <https://trac.webkit.org/changeset/267024> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408723 [details]. Comment on attachment 408723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408723&action=review > Source/WebCore/layout/display/DisplayLayerController.h:52 > + LayerController(View&); explicit > Source/WebCore/layout/display/DisplayView.h:52 > + View(FrameView&); explicit |