| Summary: | [LFC][IFC] Add support for non-root-inline-box line spacing | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zalan
2020-09-12 05:48:01 PDT
Created attachment 408591 [details]
Patch
Created attachment 408592 [details]
Patch
Comment on attachment 408592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408592&action=review > Source/WebCore/layout/inlineformatting/InlineLineBox.h:116 > + using InlineBoxMap = HashMap<const Box*, InlineBox*>; > + const InlineBoxMap::ValuesConstIteratorRange inlineBoxList() const { return m_inlineBoxRectMap.values(); } Maybe this can return 'auto' and void defining a type? Created attachment 408598 [details]
Patch
(In reply to Antti Koivisto from comment #3) > Comment on attachment 408592 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408592&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBox.h:116 > > + using InlineBoxMap = HashMap<const Box*, InlineBox*>; > > + const InlineBoxMap::ValuesConstIteratorRange inlineBoxList() const { return m_inlineBoxRectMap.values(); } > > Maybe this can return 'auto' and void defining a type? Yeah, it works! It's so much better! Thanks. Created attachment 408599 [details]
Patch
Created attachment 408600 [details]
Patch
Committed r266978: <https://trac.webkit.org/changeset/266978> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408600 [details]. |