| Summary: | [webkitscmpy] Add Contributor object | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, webkit-bug-importer, zhifei_fang | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=215862 https://bugs.webkit.org/show_bug.cgi?id=216404 |
||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-09-11 04:26:01 PDT
At some point in the future, this class will be populated by contributors.json, but at the moment, this class is just used to parse out a contributor from changelogs. This change is being used to support https://bugs.webkit.org/show_bug.cgi?id=216404 Created attachment 408535 [details]
Patch
Comment on attachment 408535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408535&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49 > +version = Version(0, 0, 5) why do we bump version number by 2? (In reply to dewei_zhu from comment #5) > Comment on attachment 408535 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408535&action=review > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49 > > +version = Version(0, 0, 5) > > why do we bump version number by 2? Because https://bugs.webkit.org/show_bug.cgi?id=216422 was also in-flight. (In reply to Jonathan Bedard from comment #6) > (In reply to dewei_zhu from comment #5) > > Comment on attachment 408535 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=408535&action=review > > > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:49 > > > +version = Version(0, 0, 5) > > > > why do we bump version number by 2? > > Because https://bugs.webkit.org/show_bug.cgi?id=216422 was also in-flight. Now, I forgot to bump the version in that patch, so it turns out that is mistake! Created attachment 408845 [details]
Patch for landing
Committed r267096: <https://trac.webkit.org/changeset/267096> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408845 [details]. |