Bug 216335

Summary: Simplify OptionSet::set
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Web Template FrameworkAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, saam, sabouhallawa, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216305
Attachments:
Description Flags
Patch sabouhallawa: review+

Ryosuke Niwa
Reported 2020-09-09 17:39:02 PDT
In https://trac.webkit.org/r266776, I added OptionSet::set. Following some discussion in https://bugs.webkit.org/show_bug.cgi?id=216305#c6, we can see that a simpler variant which uses a branch produces the same assembly in x86_64 and arm64 with -O3. So just use a simpler code since it's easier to read.
Attachments
Patch (3.13 KB, patch)
2020-09-09 18:10 PDT, Ryosuke Niwa 		sabouhallawa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2020-09-09 18:10:27 PDT
Created attachment 408390 [details] Patch
Said Abou-Hallawa
Comment 2 2020-09-09 19:09:32 PDT
Comment on attachment 408390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408390&action=review > Source/WTF/ChangeLog:3 > + Simply OptionSet::set Did you mean to write "Simplify"?
Ryosuke Niwa
Comment 3 2020-09-09 20:24:56 PDT
(In reply to Said Abou-Hallawa from comment #2) > Comment on attachment 408390 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408390&action=review > > > Source/WTF/ChangeLog:3 > > + Simply OptionSet::set > > Did you mean to write "Simplify"? Oops, indeed.
Ryosuke Niwa
Comment 4 2020-09-09 20:40:25 PDT
Committed r266812: <https://trac.webkit.org/changeset/266812>
Radar WebKit Bug Importer
Comment 5 2020-09-09 20:41:29 PDT
<rdar://problem/68615785>
Note You need to log in before you can comment on or make changes to this bug.