Bug 216335

Summary: Simplify OptionSet::set
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Web Template FrameworkAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, saam, sabouhallawa, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216305
Attachments:
Description Flags
Patch sabouhallawa: review+

Description Ryosuke Niwa 2020-09-09 17:39:02 PDT 
In https://trac.webkit.org/r266776, I added OptionSet::set.

Following some discussion in https://bugs.webkit.org/show_bug.cgi?id=216305#c6,
we can see that a simpler variant which uses a branch produces the same assembly in x86_64 and arm64 with -O3.

So just use a simpler code since it's easier to read.
Comment 1 Ryosuke Niwa 2020-09-09 18:10:27 PDT 
Created attachment 408390 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-09-09 19:09:32 PDT 
Comment on attachment 408390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408390&action=review

> Source/WTF/ChangeLog:3
> +        Simply OptionSet::set

Did you mean to write "Simplify"?
Comment 3 Ryosuke Niwa 2020-09-09 20:24:56 PDT 
(In reply to Said Abou-Hallawa from comment #2)
> Comment on attachment 408390 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408390&action=review
> 
> > Source/WTF/ChangeLog:3
> > +        Simply OptionSet::set
> 
> Did you mean to write "Simplify"?

Oops, indeed.
Comment 4 Ryosuke Niwa 2020-09-09 20:40:25 PDT 
Committed r266812: <https://trac.webkit.org/changeset/266812>
Comment 5 Radar WebKit Bug Importer 2020-09-09 20:41:29 PDT 
<rdar://problem/68615785>