| Summary: | Update WPT test harness so that webaudio tests output results that are consistent across different machines | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, ryanhaddad, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=161693 | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 212611 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Chris Dumez
2020-09-09 15:43:05 PDT
Created attachment 408379 [details]
Patch
Created attachment 408464 [details]
Patch
Created attachment 408478 [details]
Patch
Created attachment 408718 [details]
Patch
Created attachment 408953 [details]
Patch
Created attachment 408955 [details]
Patch
Comment on attachment 408955 [details]
Patch
rs=me
Committed r267167: <https://trac.webkit.org/changeset/267167> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408955 [details]. (In reply to EWS from comment #8) > Committed r267167: <https://trac.webkit.org/changeset/267167> This broke following two layout tests on ios-wk2 as also indicated by EWS (in https://ews-build.webkit.org/#/builders/24/builds/25874) - imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html - media/now-playing-status-without-media.html (In reply to Aakash Jain from comment #10) > (In reply to EWS from comment #8) > > Committed r267167: <https://trac.webkit.org/changeset/267167> > This broke following two layout tests on ios-wk2 as also indicated by EWS > (in https://ews-build.webkit.org/#/builders/24/builds/25874) > > - > imported/w3c/web-platform-tests/webaudio/the-audio-api/the- > mediaelementaudiosourcenode-interface/ > mediaElementAudioSourceToScriptProcessorTest.html > - media/now-playing-status-without-media.html This patch unskipped a lot of audio tests. Odds are these two either need iOS baselines or need to be reskipped if still flaky. I will check. (In reply to Chris Dumez from comment #11) > (In reply to Aakash Jain from comment #10) > > (In reply to EWS from comment #8) > > > Committed r267167: <https://trac.webkit.org/changeset/267167> > > This broke following two layout tests on ios-wk2 as also indicated by EWS > > (in https://ews-build.webkit.org/#/builders/24/builds/25874) > > > > - > > imported/w3c/web-platform-tests/webaudio/the-audio-api/the- > > mediaelementaudiosourcenode-interface/ > > mediaElementAudioSourceToScriptProcessorTest.html I rebaselined this test in: http://trac.webkit.org/r267238 Will monitor to see if it is still flaky or not. > > - media/now-playing-status-without-media.html This one looks green on the flakiness dashboard and looks unrelated to my change. |