| Summary: | Fix precision issues in AudioParamTimeline when event times are very close | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 212611 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2020-09-08 11:49:16 PDT
Created attachment 408250 [details]
Patch
Comment on attachment 408250 [details]
Patch
I see that the code involves a lot of floating point division. Last time I checked, I believe floating point multiplication was significantly faster. Perhaps we can make some of this division be multiplication by calculating a reciprocal or by reorganizing expressions. Or perhaps this kind of micro-optimization thinking is not relevant to this code.
r=me assuming the tests pass
Created attachment 408252 [details]
Patch
Created attachment 408255 [details]
Patch
Committed r266746: <https://trac.webkit.org/changeset/266746> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408255 [details]. |