| Summary: | [GTK] AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Gorse <mgorse> | ||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, darin, mgorse | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mike Gorse
2020-09-07 15:10:03 PDT
Created attachment 408199 [details]
Patch.
Comment on attachment 408199 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=408199&action=review > Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:140 > + return false; We’d like to structure the #if so there is not dead code after a return. So the code after the #endif should be moved before the #else. Created attachment 408202 [details]
Patch.
Comment on attachment 408202 [details] Patch. Hello! Thanks for the patch, Michael. Could you please move the “return” around as suggested by Darin? Other than that and adding the [WPE] tag to the bug description, the change looks good =) View in context: https://bugs.webkit.org/attachment.cgi?id=408202&action=review > Source/WebKit/ChangeLog:3 > + AcceleratedBackingStoreWayland might erroneously try to use SHM with older wpebackend-fdo Let's also add the [WPE] tag to the bug description :) This is a gtk bug, not WPE Created attachment 408227 [details]
Patch.
Updated ChangeLog entry. I believe I have also done what Darin requested in terms of the return value.
Committed r266726: <https://trac.webkit.org/changeset/266726> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408227 [details]. |