| Summary: | [css-flex] Don't skip flexboxes with auto height for percentage computations in quirks mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2020-09-07 12:32:58 PDT
Created attachment 408193 [details]
Patch
Comment on attachment 408193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408193&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:291 > + // We need the containing block to have a definite block-size in order to resolve the block-size of the descendant, > + // except when in quirks mode. Flexboxes follow strict behavior even in quirks mode, though. > + if (!cb || (document().inQuirksMode() && !cb->isFlexibleBoxIncludingDeprecated())) This pretty much sums up what I dislike about the current RenderTree design. Committed r266716: <https://trac.webkit.org/changeset/266716> |