| Summary: | [WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, cdumez, darin, ews-watchlist, glenn, gyuyoung.kim, jbedard, ryuan.choi, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2020-09-06 15:11:47 PDT
I keep finding myself running into issues with preprocess-idls.pl, mostly due to its very optimistic parsing of IDL files not matching the actual IDL grammar. One day, I would like to remove this alternative parsing, but as a first step, I want to add a mode I can run preprocess-idls.pl in that uses the real IDL parser to validate that the regex based one is getting the right results. Created attachment 408144 [details]
Patch
Oh bummer, looks like I can't 'use experimental 'smartmatch';' Created attachment 408148 [details]
Patch
Created attachment 408149 [details]
Patch
Committed r266687: <https://trac.webkit.org/changeset/266687> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408149 [details]. |