| Summary: | ConvolverNode incorrectly outputs silence because m_reverb is null | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 212611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-09-06 14:21:24 PDT
Created attachment 408133 [details]
Patch
Comment on attachment 408133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408133&action=review > Source/WebCore/Modules/webaudio/ConvolverNode.h:-63 > - void initialize() final; > - void uninitialize() final; Can we refactor to get rid of these across the board? Are they valuable? (In reply to Darin Adler from comment #2) > Comment on attachment 408133 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408133&action=review > > > Source/WebCore/Modules/webaudio/ConvolverNode.h:-63 > > - void initialize() final; > > - void uninitialize() final; > > Can we refactor to get rid of these across the board? Are they valuable? Some of them do initialize() / uninitialize() things. I will have to look into it more to see if we can simplify. Created attachment 408135 [details]
Patch
Committed r266684: <https://trac.webkit.org/changeset/266684> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408135 [details]. |