| Summary: | iOS: <attachment>'s QuickLook thumbnails can appear squished | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, megan_gardner, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Tim Horton
2020-09-04 18:07:52 PDT
Created attachment 408060 [details]
Patch
Created attachment 408210 [details]
Patch
Created attachment 408211 [details]
Patch
I understand the WebKit1 failures (need to skip the test), but I don't understand why the <attachment> isn't there in Mojave WK2. Created attachment 408239 [details]
Patch
Created attachment 408240 [details]
Patch
Comment on attachment 408240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408240&action=review > LayoutTests/fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html:23 > + let intervalID = setInterval(function () { Nit - maybe you could use `shouldBecomeDifferent` here instead of `setInterval`? Created attachment 408243 [details]
Patch
Committed r266743: <https://trac.webkit.org/changeset/266743> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408243 [details]. |