Bug 216173

Summary: Binding generator is not always computing the right interface attributes
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, esprehn+autocc, ews-watchlist, glenn, jbedard, kangil.han, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2020-09-04 03:40:08 PDT 
Binding generator is not always computing the right interface attributes
Comment 1 youenn fablet 2020-09-04 03:45:38 PDT 
Created attachment 407954 [details]
Patch
Comment 2 youenn fablet 2020-09-04 05:55:31 PDT 
Created attachment 407963 [details]
Patch
Comment 3 Alex Christensen 2020-09-04 08:29:29 PDT 
Comment on attachment 407963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407963&action=review

> Source/WebCore/dom/TextEncoder.idl:-27
> -    Exposed=(Window,Worker),

I also added "dictionary" to Exposed in IDLAttributes.json which should probably be removed with this.
Comment 4 youenn fablet 2020-09-04 09:24:34 PDT 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 407963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407963&action=review
> 
> > Source/WebCore/dom/TextEncoder.idl:-27
> > -    Exposed=(Window,Worker),
> 
> I also added "dictionary" to Exposed in IDLAttributes.json which should
> probably be removed with this.

OK, will fix it in a follow-up
Comment 5 EWS 2020-09-04 09:40:15 PDT 
Committed r266615: <https://trac.webkit.org/changeset/266615>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407963 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-04 09:42:29 PDT 
<rdar://problem/68350821>
Comment 7 Sam Weinig 2020-09-04 10:24:12 PDT 
Comment on attachment 407963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407963&action=review

>>> Source/WebCore/dom/TextEncoder.idl:-27
>>> -    Exposed=(Window,Worker),
>> 
>> I also added "dictionary" to Exposed in IDLAttributes.json which should probably be removed with this.
> 
> OK, will fix it in a follow-up

Exposed is not valid on a dictionary, see https://heycam.github.io/webidl/#Exposed for the complete list of valid contexts.