Bug 216148

Summary: [WebIDL] Replace 'serializable' with '[Default] object toJSON()'
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, joepeck, kangil.han, kondapallykalyan, macpherson, menard, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2020-09-03 15:26:33 PDT 
[WebIDL] Replace 'serializable' with '[Default] object toJSON()'
Comment 1 Sam Weinig 2020-09-03 15:27:18 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-03 17:00:26 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-04 09:22:45 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-04 11:23:35 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-09-04 11:25:58 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-09-04 13:28:00 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2020-09-04 13:52:35 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-09-04 15:18:35 PDT Comment hidden (obsolete)
Comment 9 Radar WebKit Bug Importer 2020-09-10 15:27:32 PDT 
<rdar://problem/68668407>
Comment 10 Sam Weinig 2020-09-13 20:12:09 PDT 
Created attachment 408675 [details]
Patch
Comment 11 Sam Weinig 2020-09-13 21:11:53 PDT 
Created attachment 408679 [details]
Patch
Comment 12 Eric Carlson 2020-09-14 08:12:28 PDT 
Comment on attachment 408679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408679&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        result. Rather, all attributes that quality as have a 'JSON type' are included

"attributes that quality as have a 'JSON type'" isn't quite right, maybe "attributes that qualify have a 'JSON type'" or "attributes that have a 'JSON type'"
Comment 13 Sam Weinig 2020-09-14 09:49:29 PDT 
Created attachment 408717 [details]
Patch
Comment 14 EWS 2020-09-14 10:21:54 PDT 
Committed r267020: <https://trac.webkit.org/changeset/267020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408717 [details].