Bug 216145

Summary: [css-grid] Incorrectly stretched SVGs without an aspect-ratio
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jenner, jfernandez, kondapallykalyan, Morningstar, pdr, rego, sabouhallawa, schenney, sebastianzartner, sergio, webkit-bug-importer, zsun
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=1114013
https://bugs.webkit.org/show_bug.cgi?id=265164
Bug Depends on: 223504    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
expectations none

Oriol Brufau
Reported 2020-09-03 14:56:43 PDT
The following WPT tests are failing in WebKit: css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-5.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-8.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-9.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-10.html https://wpt.fyi/results/css/css-grid/alignment?label=master&label=experimental&aligned&q=grid-item-no-aspect-ratio-stretch Most of them (except 6 and 7) also fail in Chromium: https://crbug.com/1114013
Attachments
Patch (6.71 KB, text/plain)
2021-03-18 13:44 PDT, zsun 		ews-feeder: commit-queue-
Details
expectations (2.03 KB, patch)
2022-02-17 11:35 PST, Dawn Morningstar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-09-10 14:57:16 PDT
<rdar://problem/68666896>
zsun
Comment 2 2021-03-18 13:44:55 PDT
Created attachment 423644 [details] Patch
Javier Fernandez
Comment 3 2021-03-18 14:29:03 PDT
Comment on attachment 423644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423644&action=review The patch looks good, but it doesn't fix all the tests that has been identified as failing due to this bug. We should either fix all of them or create a different bug, which this will depend on, and provide this patch as fix for that. > Source/WebCore/ChangeLog:8 > + When SVG element has fixed width or height as 0, it should also be reflected as true for has s/for has/for > Source/WebCore/ChangeLog:10 > + RenderReplaced::computeReplacedLogicalHeight. This change is to differentiate the case when Could you explain a bit more the case we want to differentiate from ? > Source/WebCore/platform/graphics/FloatSize.h:75 > + bool hasWidth = false; Give than we set it to true if the Length value assigned to FloatSize attributes is Fixed or not, wouldn't be better to define these attributes as isFixed ? > Source/WebCore/rendering/svg/RenderSVGRoot.cpp:83 > + intrinsicSize.hasWidth = svgSVGElement().intrinsicWidth().isFixed(); The function computeIntrinsicRatioInformation is overridden by RenderImage as well; shouldn't this class set values to the hasWidth and hasHeight as well ? Otherwise, we'll use the default values for these FloatSize's fields in the RenderReplaced logic. Additionally, are you sure that isFixed is enough ? Wouldn't be better to check use Length::isSpeficied() instead ? (it includes percent or calculated as well).
zsun
Comment 4 2021-03-19 03:29:19 PDT
Fixes on css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7.html are now at https://bugs.webkit.org/show_bug.cgi?id=223504
Dawn Morningstar
Comment 5 2022-02-17 11:35:41 PST
Created attachment 452396 [details] expectations
Dawn Morningstar
Comment 6 2022-02-17 11:36:27 PST
*** Bug 236792 has been marked as a duplicate of this bug. ***
Robert Jenner
Comment 7 2022-02-17 11:39:09 PST
Comment on attachment 452396 [details] expectations Clearing flags on attachment: 452396 Committed r290038 (247416@trunk): <https://commits.webkit.org/247416@trunk>
Dawn Morningstar
Comment 8 2022-02-17 11:50:54 PST
(In reply to Robert Jenner from comment #7) > Comment on attachment 452396 [details] > expectations > > Clearing flags on attachment: 452396 > > Committed r290038 (247416@trunk): <https://commits.webkit.org/247416@trunk> I authored this commit, and Robert landed it for me, the purpose of the commit was to change the expectations on the two tests that did not receive changes, to relieve the EWS queue backlog.
zsun
Comment 9 2022-05-13 02:26:48 PDT
My intention was only to fix css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7.html and they are being addressed at bug 223504.
Note You need to log in before you can comment on or make changes to this bug.