Bug 216133

Summary: Web Inspector: Timelines: record button disappears when UI is narrow
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hi: review+
[Video] With patch applied
none
Patch
nvasilyev: review-, nvasilyev: commit-queue-
Patch none

Description Nikita Vasilyev 2020-09-03 11:18:43 PDT 
<rdar://55875921>
Comment 1 Nikita Vasilyev 2020-09-03 11:21:43 PDT 
Created attachment 407896 [details]
Patch
Comment 2 Nikita Vasilyev 2020-09-03 11:23:18 PDT 
Created attachment 407898 [details]
[Video] With patch applied
Comment 3 Devin Rousso 2020-09-03 11:28:21 PDT 
Comment on attachment 407896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407896&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:49
> +        this._recordButton.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;

we should also do this to `_continueButton`, as it's shown instead of `_recordButton` when ⌥ is pressed and the active recording will auto-stop (`WI.TimelineTabContentView.prototype._updateNavigationBarButtons`)
Comment 4 Nikita Vasilyev 2020-09-03 11:31:12 PDT Comment hidden (obsolete)
Comment 5 Nikita Vasilyev 2020-09-03 11:31:54 PDT 
Created attachment 407900 [details]
Patch
Comment 6 EWS 2020-09-03 12:17:05 PDT 
Committed r266537: <https://trac.webkit.org/changeset/266537>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407900 [details].