| Summary: | Make AudioParam.cancelScheduledValues() standards compliant | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 212611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-09-03 11:10:44 PDT
Created attachment 407895 [details]
Patch
Comment on attachment 407895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407895&action=review r=me > Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp:165 > + if (eventTime >= cancelTime || ((m_events[i].type() == ParamEvent::SetValueCurve) > + && eventTime <= cancelTime && (eventTime + m_events[i].duration() > cancelTime))) { This condition clause might read more easily as a helper lambda called as "isAfter(m_events[I], cancelTime)". Created attachment 407912 [details]
Patch
Comment on attachment 407912 [details] Patch Clearing flags on attachment: 407912 Committed r266558: <https://trac.webkit.org/changeset/266558> All reviewed patches have been landed. Closing bug. |