| Summary: | Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefox, and the specification | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist, peng.liu6, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 407802 [details]
Patch
Created attachment 407808 [details]
Patch
Created attachment 407821 [details]
Patch
Comment on attachment 407821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407821&action=review > Source/WebCore/platform/text/TextCodecSingleByte.cpp:36 > +const UChar iso88593[128] { Use constexpr like others? Created attachment 407832 [details]
Patch
Looks like I need to update fast/encoding/char-decoding.html also. Will do. Comment on attachment 407832 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407832&action=review > Source/WTF/wtf/PlatformHave.h:740 > +#define HAVE_ICU_WITH_CORRECT_WINDOWS_1255 1 This was optimistic. Big Sur and iOS14 have an ICU that is more correct but not completely correct. I'll remove this and just use the table everywhere. |
Align ISO-8859-{3,6,7,8} and windows-{874,1253} encodings with Chrome, Firefox, and the specification