| Summary: | REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to initialize m_length | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Text | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 191242 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 407792 [details]
Patch v1
Comment on attachment 407792 [details]
Patch v1
Technically there is no path there, but I guess it doesn't hurt?
(In reply to Tim Horton from comment #2) > Comment on attachment 407792 [details] > Patch v1 > > Technically there is no path there, but I guess it doesn't hurt? Yes. this is a hardening fix. Comment on attachment 407792 [details]
Patch v1
Adding cq+ since failures in fast/block/margin-collapse/103.html are happening across multiple patches. Not related to this patch.
Committed r266531: <https://trac.webkit.org/changeset/266531> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407792 [details]. |
WebCore::TextDecorationThickness constructor fails to initialize m_length. Regressed here: Bug 191242: Parsing support for text-underline-offset and text-decoration-thickness <https://bugs.webkit.org/show_bug.cgi?id=191242> <https://trac.webkit.org/r237835> Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker.