Bug 216091

Summary:

Fix rounding for DelayDSPKernel's buffer size calculation

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

212611

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2020-09-02 12:53:50 PDT

Fix rounding for DelayDSPKernel's buffer size calculation. The DelayNode needs to buffer |maxDelayTime| sample frames, plus one frame for interpolation. If |maxDelayTime| isn't an integer, we have to round it up or the buffer would end up one frame short.

Comment 1 Chris Dumez 2020-09-02 12:55:08 PDT

Created attachment 407789 [details]
Patch

Comment 2 Geoffrey Garen 2020-09-02 12:58:57 PDT

Comment on attachment 407789 [details]
Patch

r=me

Comment 3 Chris Dumez 2020-09-02 15:07:30 PDT

Comment on attachment 407789 [details]
Patch

Clearing flags on attachment: 407789

Committed r266491: <https://trac.webkit.org/changeset/266491>

Comment 4 Chris Dumez 2020-09-02 15:07:32 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2020-09-02 15:08:16 PDT

<rdar://problem/68235721>