| Summary: | Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2020-09-02 11:36:43 PDT
Created attachment 407796 [details]
patch
Comment on attachment 407796 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=407796&action=review > Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1039 > + hash = "<nil"_s; will fix to <nil> Created attachment 407797 [details]
patch
Comment on attachment 407797 [details]
patch
r=me
Traceback (most recent call last):
File "Tools/Scripts/webkit-patch", line 42, in <module>
from webkitpy.tool.main import WebKitPatch
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/main.py", line 41, in <module>
from webkitpy.tool import commands
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/__init__.py", line 16, in <module>
from webkitpy.tool.commands.queries import *
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/queries.py", line 45, in <module>
from webkitpy.common.net.buildbot import BuildBot
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py", line 5, in <module>
from .buildbot import BuildBot, Builder, Build
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 43, in <module>
from webkitpy.thirdparty.autoinstalled.mechanize import Browser
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 97, in find_module
self._install_mechanize()
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 138, in _install_mechanize
self._install_html5lib()
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 134, in _install_html5lib
"html5lib-1.0.1/html5lib")
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 279, in _install
return installer.install(url=url, url_subpath=url_subpath, target_name=target_name)
File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 540, in install
raise Exception(message)
Exception: Error auto-installing the html5lib package to:
"/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/autoinstalled/html5lib"
--> Inner message: Command '['curl', 'https://files.pythonhosted.org/packages/85/3e/cf449cf1b5004e87510b9368e7a5f1acd8831c2d6691edd3c62a0823f98f/html5lib-1.0.1.tar.gz', '-L', '--output', '/var/folders/33/15r3ggyd4fb52p4t38_rbd9w0000gn/T/html5lib_ymPUTH/html5lib-1.0.1.tar.gz']' returned non-zero exit status 7
Committed r266560: <https://trac.webkit.org/changeset/266560> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407797 [details]. |