| Summary: | Expose RTCPeerConnection.restartIce | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-09-02 05:44:36 PDT
Created attachment 407759 [details]
Patch
Created attachment 407760 [details]
Patch
Created attachment 407769 [details]
Patch
Comment on attachment 407769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407769&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:127 > + void restartIce() { m_backend->restartIce(); } No null check needed here? (In reply to Darin Adler from comment #4) > Comment on attachment 407769 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407769&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.h:127 > > + void restartIce() { m_backend->restartIce(); } > > No null check needed here? The model is a bit weird right now so we cannot have a UniqueRef, as we would probably like. Basically RTCPeerConnection constructor creates the backend and RTCPeerConnection::create makes sure a peer connection has a backend, or it throws and deallocate the RTCPeerConnection. I can probably refactor this to use a UniqueRef and clarify this. Committed r266511: <https://trac.webkit.org/changeset/266511> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407769 [details]. |