Bug 216063

Summary: Allow direct creation of replacement codec
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-09-01 19:37:17 PDT 
Allow direct creation of replacement codec
Comment 1 Alex Christensen 2020-09-01 19:38:09 PDT 
Created attachment 407732 [details]
Patch
Comment 2 youenn fablet 2020-09-02 02:55:34 PDT 
Some tests need rebasing, some tests need investigation (fast/encoding/charset-replacement.html).
Comment 3 Alex Christensen 2020-09-02 07:49:58 PDT 
Created attachment 407765 [details]
Patch
Comment 4 youenn fablet 2020-09-02 08:37:12 PDT 
Comment on attachment 407765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407765&action=review

> LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings.any-expected.txt:12
> +PASS replacement - non-empty input decodes to one replacement character. 

imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt might need rebasing as well.
Comment 5 Alex Christensen 2020-09-02 08:40:46 PDT 
Created attachment 407770 [details]
Patch
Comment 6 Alex Christensen 2020-09-02 08:52:42 PDT 
http://trac.webkit.org/r266466
Comment 7 Radar WebKit Bug Importer 2020-09-02 08:53:14 PDT 
<rdar://problem/68212529>
Comment 8 Darin Adler 2020-09-02 21:30:21 PDT 
This test is broken on Windows now:

fast/encoding/charset-replacement.html

I think it needs to be rebased for Windows.
Comment 9 Alex Christensen 2020-09-02 22:28:15 PDT 
https://trac.webkit.org/changeset/266504/webkit
Comment 10 Alex Christensen 2020-09-03 09:15:13 PDT 
And iOS https://trac.webkit.org/changeset/266522/webkit
Comment 11 Alexey Proskuryakov 2020-09-03 17:47:21 PDT 
Comment on attachment 407770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407770&action=review

> LayoutTests/ChangeLog:9
> +        * fast/encoding/charset-replacement-expected.txt:
> +        * fast/encoding/charset-replacement.html:

Why was it necessary to make this test a render tree dump?
Comment 12 Darin Adler 2020-09-05 15:32:15 PDT 
Comment on attachment 407770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407770&action=review

>> LayoutTests/ChangeLog:9
>> +        * fast/encoding/charset-replacement.html:
> 
> Why was it necessary to make this test a render tree dump?

That does seem like a step in the wrong direction.
Comment 13 Darin Adler 2020-09-05 15:32:16 PDT 
Comment on attachment 407770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407770&action=review

>> LayoutTests/ChangeLog:9
>> +        * fast/encoding/charset-replacement.html:
> 
> Why was it necessary to make this test a render tree dump?

That does seem like a step in the wrong direction.