| Summary: | Make sure BiquadFilterNode tail is getting processed | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212611 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-09-01 14:00:53 PDT
Created attachment 407710 [details]
Patch
Comment on attachment 407710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407710&action=review > Source/WebCore/Modules/webaudio/PannerNode.cpp:547 > + return m_panner ? m_panner->requiresTailProcessing() : true; I would write this as: return !m_panner || m_panner->requiresTailProcessing(); For me that seems more readable. Maybe other people find the ? : form more readable? > Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp:355 > + return m_panner ? m_panner->requiresTailProcessing() : true; Ditto. Committed r266417: <https://trac.webkit.org/changeset/266417> |