Bug 216043

Summary: Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jbedard, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2020-09-01 10:15:32 PDT 
Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
Comment 1 Yusuke Suzuki 2020-09-01 10:22:02 PDT 
Created attachment 407692 [details]
Patch
Comment 2 Yusuke Suzuki 2020-09-01 10:22:05 PDT 
<rdar://problem/66394369>
Comment 3 Mark Lam 2020-09-01 10:46:20 PDT 
Comment on attachment 407692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review

r=me with fix

> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124
> +    return JSValue::encode(jsBoolean(Gigacage::isEnabled()));

Can you add `DollarVMAssertScope assertScope;` before this line?
Comment 4 Yusuke Suzuki 2020-09-01 11:30:37 PDT 
Comment on attachment 407692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review

Thanks!

>> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124
>> +    return JSValue::encode(jsBoolean(Gigacage::isEnabled()));
> 
> Can you add `DollarVMAssertScope assertScope;` before this line?

Added.
Comment 5 Yusuke Suzuki 2020-09-01 19:18:10 PDT 
Committed r266447: <https://trac.webkit.org/changeset/266447>