| Summary: | Fix crash during WebPage constructor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2020-08-31 21:06:44 PDT
Created attachment 407656 [details]
Patch
Found 16 new test failures: fast/css/continuationCrash.html, fast/css/text-overflow-input.html, fast/forms/button-positioned.html, fast/forms/button-sizes.html, fast/forms/input-button-sizes.html, fast/forms/input-disabled-color.html, fast/forms/input-readonly-dimmed.html, fast/forms/input-text-word-wrap.html, fast/forms/listbox-bidi-align.html, fast/forms/select-change-popup-to-listbox.html ... Committed r266395: <https://trac.webkit.org/changeset/266395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407656 [details]. Comment on attachment 407656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407656&action=review > Source/WebKit/WebProcess/WebProcess.cpp:1149 > + // This can be called during a WebPage's constructor, so wait until after the constructor returns to touch the WebPage. > + RunLoop::main().dispatch([this] { I can see what issue you are fixing, but delaying on a timer is a super risky approach. What else can happen between now and when the timer fires? This leaves the page in an inconsistent state with no guarantee that it will remain dormant until the state is corrected. |