| Summary: | Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bdakin, hi, megan_gardner, mjs, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tim Horton
2020-08-31 18:57:17 PDT
Created attachment 407647 [details]
Patch
Comment on attachment 407647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407647&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8604 > + const char *warningVersion = ""; Nit - * on the other side. I think you could also remove the `BOOL& shouldLogWarning` argument if you initialized this string to null, and then just checked for a non-null warningVersion below instead. Created attachment 407696 [details]
Patch
Created attachment 407697 [details]
Patch
Created attachment 407699 [details]
Patch
Committed r266407: <https://trac.webkit.org/changeset/266407> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407699 [details]. |